device handling fix #159
Merged
device handling fix #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs if the environment isn't initalized with the correct device_str
|
Essentially, with this change, we would get the usual pytorch error of incompatible devices instead, right? |
|
Yea exactly, it’s up to the user to ensure everything is on the correct
device explicitly
Joseph (Mobile)
…On Sun, Feb 18, 2024 at 08:39 saleml ***@***.***> wrote:
Essentially, with this change, we would get the usual pytorch error of
incompatible devices instead, right?
—
Reply to this email directly, view it on GitHub
<#159 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7TL2VHYP2QORKP4PNTWD3YUIAANAVCNFSM6AAAAABDM55KACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGMZDSMBQGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
saleml
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a "feature" whereby the
NeuralNetwould automatically cast tensors to a particular device. This would have the strange side effect of moving a part of thegflownetinstance to an unexpected device, causing a bug that is confusing to track down.Instead, the code will now fail in a sensible way if the user does not cast tensors to the correct device, making debugging easy.
This might require slightly more thought in the case where one has multiple environments running on difference devices, but we can address this in a follow up PR.